ui-accordion open=0 gets an argument error

[blueforce]

Steps to reproduce:

1. User Shortcode Accordeon
2. Set [ui-accordion independent=false open=0]
3. see result

Failure:
Server Error
Sorry, something went terribly wrong!

0 - Argument 1 passed to Grav\Plugin\ShortcodeManager::getId() must implement interface Thunder\Shortcode\Shortcode\ShortcodeInterface, null given, called in root/user/plugins/shortcode-ui/shortcodes/AccordionsShortcode.php on line 33

Tested with:

• UI Shortcode v2.2.5
• PHP 7.2.x
• Grav v1.5.6
• Admin v1.8.15

[rhukster]

Well i've looked into this and it appears to be a bug in the upstream shortcode library. Basically, the open=0 is causing the top parent of the child item to be null. If you use: open="0" it works fine.

It seems to be a problem specifically with the regular parser, as wordpress and regex work fine.

[blueforce]

no code added? is there a workarround?

[rhukster]

The fix was 'downstream' in the thunderer/shortcode library we use:

getgrav/grav-plugin-shortcode-core@f1359f3

[rhukster]

also i put workarounds while we were waiting for the updated release of the library here: #29 (comment)

[blueforce]

thanks a lot, much appricieated

[iamalive-now]

Hi
I've just started a new site and have added the shortcode ui plugin.
I'm getting much the same error as described above:

"Argument 1 passed to Grav\Plugin\ShortcodeCore\ShortcodeManager::getId() must implement interface Thunder\Shortcode\Shortcode\ShortcodeInterface, null given, called in /home/iamalive/mysite.com/user/plugins/shortcode-ui/classes/shortcodes/AccordionsShortcode.php on line 34 ◀"

I'm using Gantry5 and the Helium Template.

Any ideas?

[rhukster]

Are you in the latest version of shortcode core??

[iamalive-now]

Hi Andy I installed via Admin panel - the whole site is only a few days old so I assume it includes all the new plugins, etc. Regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394

…

On Sun, 7 Mar 2021 at 17:09, Andy Miller ***@***.***> wrote: Are you in the latest version of shortcode core?? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATD3X2GM7ABXLOEHCMB5RUTTCOQJ7ANCNFSM4GOMKGRQ> .

[rhukster]

Can you paste your md content?

[iamalive-now]

Hi Andy I probably could, but not sure where to look and exactly which md file you mean. I'm happy to give you full access: [EDIT: credentials have been moved out -Matias] Hope that helps. Regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394

…

On Sun, 7 Mar 2021 at 19:27, Andy Miller ***@***.***> wrote: Can you paste your md content? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATD3X2GOC7EFHITJX4MJ2ETTCPAPJANCNFSM4GOMKGRQ> .

[iamalive-now]

Hi again Andy Just to follow up: on my site I have a page called "Terms & Conditions" where I have experimented with the accordion shortcode. This is where the error message can be seen on the frontend. Incidentally, I'd like to take the opportunity to thank you for your many achievements, which have directly contributed to me being able to earn a living for the past 17 years, starting with Joomla Version and Rockettheme practically from the beginning. I am very impressed by you and your teams. Regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394

…

On Sun, 7 Mar 2021 at 20:34, David Jakob ***@***.***> wrote: Hi Andy I probably could, but not sure where to look and exactly which md file you mean. Hope that helps. Regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394 On Sun, 7 Mar 2021 at 19:27, Andy Miller ***@***.***> wrote: > Can you paste your md content? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#29 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATD3X2GOC7EFHITJX4MJ2ETTCPAPJANCNFSM4GOMKGRQ> > . >

[mahagr]

@iamalive-now Please do not send any login credentials into a public discussion (you replied to GitHub notification). I removed them from the GitHub discussion.

[iamalive-now]

Follow up: I have found the error - I had not added the closing tag for the accordion! My bad! My apologies. Best regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394

…

On Mon, 8 Mar 2021 at 08:13, David Jakob ***@***.***> wrote: Hi again Andy Just to follow up: on my site I have a page called "Terms & Conditions" where I have experimented with the accordion shortcode. This is where the error message can be seen on the frontend. Incidentally, I'd like to take the opportunity to thank you for your many achievements, which have directly contributed to me being able to earn a living for the past 17 years, starting with Joomla Version and Rockettheme practically from the beginning. I am very impressed by you and your teams. Regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394 On Sun, 7 Mar 2021 at 20:34, David Jakob ***@***.***> wrote: > Hi Andy > > I probably could, but not sure where to look and exactly which md file > you mean. > > Hope that helps. > > Regards > David > > David Jakob > Längmattstrasse 31 > CH-4632 Trimbach > Switzerland > Tel.:+41 62 535 4394 > > > > On Sun, 7 Mar 2021 at 19:27, Andy Miller ***@***.***> > wrote: > >> Can you paste your md content? >> >> — >> You are receiving this because you commented. >> Reply to this email directly, view it on GitHub >> <#29 (comment)>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/ATD3X2GOC7EFHITJX4MJ2ETTCPAPJANCNFSM4GOMKGRQ> >> . >> >

[iamalive-now]

Hi Matias Ooops! Sorry - I didn't realise it would get publicly published. Thanks for removing that!!! I've deleted that account already. Best regards David David Jakob Längmattstrasse 31 CH-4632 Trimbach Switzerland Tel.:+41 62 535 4394

…

On Mon, 8 Mar 2021 at 08:44, Matias Griese ***@***.***> wrote: @iamalive-now <https://github.com/iamalive-now> Please do not send any login credentials into a public discussion (you replied to GitHub notification). I removed them from the GitHub discussion. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATD3X2CCITJPAEXM6BWOGH3TCR563ANCNFSM4GOMKGRQ> .