-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube embed plugin #13
Comments
Hi, i can help you with implementation, but there are a few clarifying questions:
Thanks. |
I think ideally it would be an If you type a generic URL and have markdown auto-link it during processing, the link would be something like: https://www.youtube.com/watch?v=rZudJiJcw3s This would then be detected via regex expression, and then replaced with the correct embed code. What do you think? |
Thanks for the answer. I think this should work. |
Some good starting point and ideas I would have personally followed to write such plugin. A regex we are using at RocketTheme for our RokBox extension that has served us pretty well over the years. /(youtube\.com|youtu\.be|youtube-nocookie\.com)\/(watch\?v=|v\/|u\/|embed\/?)?(videoseries\?list=(.*)|[\w-]{11}|\?listType=(.*)&list=(.*)).*/i Matches the
where the protocol We also opened these settings to the user to toggle:
Probably not all needed but some are definitely good to have, like the |
Thanks @w00fz, I will definitely use it. |
@rhukster, @w00fz you can see plugin here: grav-plugin-videoembed. Will be happy hear your critic and suggestions. |
Ah very cool! Will check it out today. Thanks! |
Very nice. Had a look at the plugin and works fine. The only couple issues I've spotted are the reprocessing of the twig The other thing is that you can't override the settings from within a page which is quite useful for customizing the settings on the fly per page. I can fork yours and put together a pull request but if you want to have a play with it, have a look at the lightslider Thanks for your contribution tho, looking good! Was even thinking that this could be expanded to more media services such as vimeo and vine. |
Yes this looks pretty solid. I agree with @w00fz regarding the twig processing. That should not be needed and will only add overhead. If you didn want to expand, the name of the plugin probalby should change to something along the lines of |
Thanks for detailed feedback. @w00fz, @rhukster, yes, adding more services is a good idea. I rename repo and add to development plan. Thanks again for responsiveness. |
Hi, you can add my plugin into plugin list on site? Or better send request about this to [email protected]? |
Congratulations your plugin is looking very good. I hope you don't mind be the guinea pig for this as you have developed our first 3rd party plugin! So we are working it out as we go :) As your plugin uses composer and is not 'ready-to-go' without it, we need to be able to link to a self contained Once you have a zip, this is the reset of the info we have for each plugin:
Demo is optional, icon is one chosen from: http://fortawesome.github.io/Font-Awesome/icons/ After we sort this all out with you, i'll create a step-by-step guide to document the process for others. Thanks so much for your contribution BTW! |
@rhukster, perhaps it would be better if the E.g.:
What you think about this? This will prevent manually adding releases, changing info ... Sorry for my bad english, i hope you understand what I mean. |
In the future we plan on having a developer 'portal' of sorts, where you can login and update this information. In the short term something like what your suggesting could work if we could ensure it was valid. we now have a caching twig plugin that lets us periodically pull stuff into twig, but even that will take some setup. For right now you'll have to provide us this info yourself i'm afraid, and we'll update it manually when you let us know there's a new release. |
It's clear. I use composer in project only for development(for testing) - project does not have any no-dev dependencies, therefore I simply add to my project Export repository as archive does not contain unnecessary files. My plugin info:
Thank you, you are doing a great job. Can I help you with something else? |
Ok awesome, we're going to do a quick test, and then assuming no issues, we'll add it to the site. Regarding other plugins, we have another one in the issues: dropbox support. Another one is something to provide flickr/500px/smugmug/etc, to produce an image gallery. Something like this would be really cool: https://wordpress.org/plugins/photonic/ It could potentially use the image class to create thumbnails automatically. What do you think? Another thing we could really do with help on is tests and coverage validation (like you've done so well on in your plugin). Not glamorous i know, but something we would like to get done. Oh one other thing, is the roadmap: http://getgrav.org/blog/grav-roadmap If you have any ideas thoughts, or want to help out with anything there, let us know! |
Really nice job on the plugin Maxim, thanks! |
Plugin is now live!!! http://getgrav.org/downloads/plugins#extras Thanks! |
Cool! Thanks! About top comment: interested ideas, I will think about it. |
BTW if you want to talk about Grav stuff, please hop on freenode IRC, #grav as that's where we hangout :) |
Another plugin request was for a YouTube embed plugin:
http://avexdesigns.com/responsive-youtube-embed/
Would be nice if youtube URL could be auto-detected and converted to an embed format.
The text was updated successfully, but these errors were encountered: