HTTP-42-BatchRequest - add support for batch request processing in HT…

…TP sink #10 - changes after Code review - fix batch split

Signed-off-by: Krzysztof Chmielewski <[email protected]>

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/BatchRequestSubmitter.java

@@ -58,32 +58,22 @@ public List<CompletableFuture<JavaNetHttpResponseWrapper>> submit(
         }
 
         var responseFutures = new ArrayList<CompletableFuture<JavaNetHttpResponseWrapper>>();
-
-        int counter = 0;
         String previousReqeustMethod = requestsToSubmit.get(0).method;
         List<HttpSinkRequestEntry> reqeustBatch = new ArrayList<>(httpRequestBatchSize);
+
         for (var entry : requestsToSubmit) {
-            if (!previousReqeustMethod.equalsIgnoreCase(entry.method)) {
+            if (reqeustBatch.size() == httpRequestBatchSize
+                || !previousReqeustMethod.equalsIgnoreCase(entry.method)) {
                 // break batch and submit
                 responseFutures.add(sendBatch(endpointUrl, reqeustBatch));
                 reqeustBatch.clear();
-                // start a new batch for new HTTP method.
-                reqeustBatch.add(entry);
-            } else {
-                reqeustBatch.add(entry);
-                if (++counter % httpRequestBatchSize == 0) {
-                    // batch is full, submit and start new batch.
-                    responseFutures.add(sendBatch(endpointUrl, reqeustBatch));
-                    reqeustBatch.clear();
-                }
             }
+            reqeustBatch.add(entry);
             previousReqeustMethod = entry.method;
         }
 
-        if (!reqeustBatch.isEmpty()) {
-            // submit anything that left
-            responseFutures.add(sendBatch(endpointUrl, reqeustBatch));
-        }
+        // submit anything that left
+        responseFutures.add(sendBatch(endpointUrl, reqeustBatch));
         return responseFutures;
     }