Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding coverage to PRs #131

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix adding coverage to PRs #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b97ecec
Fix adding coverage to PRs
Oct 17, 2024
868ee02
Remove continue-on-error
Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

- name: Add coverage to PR
id: jacoco
uses: madrapps/jacoco-report@v1.2
uses: madrapps/jacoco-report@v1.7.1
with:
paths: ${{ github.workspace }}/target/site/jacoco/jacoco.xml
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ under the License.
<assertj.core.version>3.21.0</assertj.core.version>
<mockito.version>4.0.0</mockito.version>
<wiremock.version>2.27.2</wiremock.version>
<jacoco.plugin.version>0.8.7</jacoco.plugin.version>
<jacoco.plugin.version>0.8.12</jacoco.plugin.version>
<maven.shade.plugin.version>3.1.1</maven.shade.plugin.version>
<mockito-inline.version>4.6.1</mockito-inline.version>
</properties>
Expand Down Expand Up @@ -298,7 +298,7 @@ under the License.
<version>3.0.0-M5</version>
<configuration>
<!-- argLine needed for Flink 1.16 and 1.17 or there are unit test errors-->
<argLine>--add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED</argLine>
<argLine>@{argLine} --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED</argLine>
</configuration>
</plugin>

Expand Down
Loading