Add GitHub CI workflow #2
Conversation
|
|
Let's wait for Maven Central repo |
|
|
.github/workflows/build.yml
Outdated
| push: | ||
| branches: | ||
| - main | ||
| - develop |
There was a problem hiding this comment.
We will probably not have a develop branch since I'm opting for using cactus model as a branch strategy.
Also, this rule here "push" -> would be good to set up master as protected branch, so no direct pushes to master will be allowed.
Also It would be very good to run CI (tests) on master AFTER merge to master.
This will ensure that any changes added to master are compatible with current master state.
In my past experience I had many cases where master was failing after merge, although feature branch was ok and passing all tests.
Ideally revert merge if that post merge build fails, but Im not sure if this last step is possible.
Additionally a good "safety" check would be if "merge" to master would not be possible if feature branch is behind master. I know that on GitLab you can configure such a rule -> disable "merge" button" if feature branch is behind master.
This forces developer to always refresh its feature branch and make sure that everything is green.
|
|
|
Signed-off-by: Krzysztof Chmielewski <[email protected]>
Signed-off-by: Krzysztof Chmielewski <[email protected]>
Signed-off-by: Krzysztof Chmielewski <[email protected]>
rc-0.9.0_testRunFix - fix publish build #2
Signed-off-by: Krzysztof Chmielewski <[email protected]>
rc-0.9.0_testRunFix - fix publish build #2
…TP sink #2 Signed-off-by: Krzysztof Chmielewski <[email protected]>
* HTTP-42-BatchRequest - add support for batch request processing in HTTP sink. Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #2 Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #3 Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #4 Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #5 tests Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #6 tests Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #7 tests Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #8 tests Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #9 tests Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP - doc. Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #9 Java doc Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #10 - changes after Code review - fix typos Signed-off-by: Krzysztof Chmielewski <[email protected]> * HTTP-42-BatchRequest - add support for batch request processing in HTTP sink #10 - changes after Code review - fix batch split Signed-off-by: Krzysztof Chmielewski <[email protected]> --------- Signed-off-by: Krzysztof Chmielewski <[email protected]>
No description provided.