fix: Recurring fee not displayed on invoices after upgrade #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
reviewed
Dec 31, 2024
Recurring fee not displayed on invoices after upgrade
... including all invoices with the same external_id. This ensure if there is any pending fee to be invoiced it will be. Be aware of, subscriptions external_id does not have unique constraints, even we are scoping the subscriptions search to the organzation... Could two customers of the same organization have the same external_id in different invoices?
but not in local
This change only fixed the issue partially, all other use cases like end of billing period were not handled as expected
finds all terminated and active subscriptions with the same external_id to invoice advance fees belonging to them.
ancorcruz
force-pushed
the
fix/recurring-fee-not-invoiced
branch
from
d9a9421 to
d145065
Compare
lovrocolic
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Steps to reproduce the issue:
Create a recurring metric;
Create a plan with a charge linked to the recurring metric - the charge should be:
Create a subscription with a start date in the past and send an event in the past (e.g. 1 December) -> you receive a fee.created webhook;
Duplicate the original plan and only modify the price of the charge (higher price);
Trigger an upgrade of the existing subscription by assigning the new plan;
Mark the fee in step 3 as succeeded via POST api/v1/fees/:lago_id
Terminate the subscription -> the fee is not included in the end-of-period invoice.
Expected behaviour: the fee should be included in the end-of-period invoice, even if the original Lago subscription to which it belongs is no longer active.
Description
This change fetches all subscriptions with status active or terminated of a given organization with a matching external id to invoice their paid in advance fees.