-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate styled-components usage of form components #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keellyp
changed the title
Migration forms
refactor: migrate styled-components usage of form
Dec 20, 2024
keellyp
changed the title
refactor: migrate styled-components usage of form
refactor: migrate styled-components usage of form componennts
Dec 20, 2024
keellyp
changed the title
refactor: migrate styled-components usage of form componennts
refactor: migrate styled-components usage of form components
Dec 20, 2024
ansmonjol
reviewed
Dec 23, 2024
ansmonjol
reviewed
Dec 23, 2024
ansmonjol
reviewed
Dec 23, 2024
ansmonjol
reviewed
Dec 23, 2024
ansmonjol
reviewed
Dec 23, 2024
ansmonjol
approved these changes
Dec 23, 2024
keellyp
force-pushed
the
migration-forms
branch
from
December 23, 2024 17:23
6a50a09
to
277b5e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of the tailwind migration
Description
Remove usage of
styled(Component)
of form components.Better to review commit by commit
Partially fixes LAGO-332