-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace webpack with vite #1944
Conversation
Hey @ManiacMaxo, thanks a ton for you time and effort. Also, few question/remark so far:
Let me know! |
Hey, I got a local docker container up and running with the API without a reverse proxy in front.
|
Ok! I'll take time later to understand what went wrong during my setup.
Also, just to mention before it happen, In order to merge this PR I'll have to re-open it on our repo directly. Otherwise the E2E Ci job will always fail. |
Cool, I'll just remove the |
Thanks a lot @ManiacMaxo 🙏! Your contributions are highly appreciated. Migrating to vite has been on our frontend roadmap for quite a while, so we're really impressed to see that you've done it. I've moved your changes in a PR: #1974. I've made you the co-author of the commits, and added some small fixes on top. I'll close this one now and we'll be merging that one tomorrow morning. |
Context
Vite + SWC is faster and more modern than Webpack + Babel.
Description
Migrated the dev + build process from webpack to vite. All webpack plugins seem to be supported in one way or another in vite so the output should be basically the same.
Some things to note:
sideEffects: false
in the package.json to reduce side-effect imports. This allowed vite to split the JsonEditor to its own chunkNext step would probably be jest to vitest but I have no previous experience with either.
Closes #1929