Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log filter times during form entry #6573

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jan 28, 2025

This adds a toast that shows the execution time for filters during form entry. The goal here is to allow developers and QA to quickly debug optimizations/changes to filter code without needing to reach for timers.

Why is this the best possible solution? Were any other approaches considered?

The biggest thing to discuss here is the change that removes Application as an arg from the ToastUtils helpers. My goal here was to make ToastUtils more like Timber or Analytics, but I'm happy to discuss if that doesn't feel write!

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Not a lot to check here other than playing around with the new "Debug filters" setting in "Experimental".

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review February 3, 2025 12:28
@seadowg seadowg requested a review from grzesiek2010 February 3, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant