Handle invalid media type error in registry pull #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added error handling for invalid media type in `PullBundle` method to ensure the provided reference is a Porter bundle. - Updated integration tests to cover the scenario of pulling a Docker image as a bundle. Signed-off-by: Kim Christensen <[email protected]>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Improves the error message when using non-bundle references.
What issue does it fix
Closes #904
Notes for the reviewer
The optimal solution would be to improve the error message in cnab-to-oci, but until that can be accomplished this at least provides a more user-friendly error message.
Checklist