-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Comment why we can't use cocoapods 1.16.2 #570
Conversation
Explain why we can't use cocoapods 1.16.2 and link a related GH issue.
# - ERROR | [iOS] unknown: Encountered an unknown error (Unable to locate the | ||
# executable `rsync`) during validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reading the error message -- do you not just want to install rsync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's worth a shot. Is this the right place to add the dependency? If not, where can I add it, @asottile-sentry?
Lines 28 to 42 in 272a995
RUN apt-get -qq update \ | |
&& apt-get install -y --no-install-recommends \ | |
apt-transport-https \ | |
build-essential \ | |
curl \ | |
default-jdk-headless \ | |
dirmngr \ | |
gnupg \ | |
git \ | |
python3-packaging \ | |
python3-venv \ | |
ruby-full \ | |
jq \ | |
unzip \ | |
maven \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that would be the place -- you can build the docker image locally and play around with it too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that before updating CocoaPods. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue, so I don't forget.
Explain why we can't use cocoapods 1.16.2 and link a related GH issue.
Follow up on #569.