Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Comment why we can't use cocoapods 1.16.2 #570

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

philipphofmann
Copy link
Member

Explain why we can't use cocoapods 1.16.2 and link a related GH issue.

Follow up on #569.

Explain why we can't use cocoapods 1.16.2 and link a related GH issue.
@philipphofmann philipphofmann requested a review from a team November 22, 2024 12:27
@philipphofmann philipphofmann merged commit bd4ea46 into master Nov 22, 2024
10 checks passed
@philipphofmann philipphofmann deleted the chore/why-cocoapods branch November 22, 2024 13:28
Comment on lines +7 to +8
# - ERROR | [iOS] unknown: Encountered an unknown error (Unable to locate the
# executable `rsync`) during validation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the error message -- do you not just want to install rsync?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's worth a shot. Is this the right place to add the dependency? If not, where can I add it, @asottile-sentry?

craft/Dockerfile

Lines 28 to 42 in 272a995

RUN apt-get -qq update \
&& apt-get install -y --no-install-recommends \
apt-transport-https \
build-essential \
curl \
default-jdk-headless \
dirmngr \
gnupg \
git \
python3-packaging \
python3-venv \
ruby-full \
jq \
unzip \
maven \

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that would be the place -- you can build the docker image locally and play around with it too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that before updating CocoaPods. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue, so I don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants