Skip to content

Commit

Permalink
fix(build): Run check when PR is ready for review (#1899)
Browse files Browse the repository at this point in the history
Make sure to run the `Changelog` check when the PR converted from Draft
to Ready for Review.
  • Loading branch information
olksdr authored Mar 1, 2023
1 parent dc47e21 commit 2c875dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/actions/changelog/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ module.exports = async ({github, context, core}) => {
pull_number: context.payload.pull_request.number,
});

if (pr.merged) {
// While in draft mode, skip the check because changelogs often cause merge conflicts.
if (pr.merged || pr.draft) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: "Changelog"
on:
pull_request:
types: [opened, synchronize, reopened, edited]
types: [opened, synchronize, reopened, edited, ready_for_review]

jobs:
build:
Expand Down

0 comments on commit 2c875dc

Please sign in to comment.