Skip to content

Commit

Permalink
ref(normalization): Increase stacktrace function and symbol length li…
Browse files Browse the repository at this point in the history
…mits to 512 chars
  • Loading branch information
Dav1dde committed Jan 9, 2025
1 parent 99dcdd5 commit 68788e0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

**Features**:

- Increase stacktrace function and symbol length limits to 512 chars. ([#4436](https://github.com/getsentry/relay/pull/4436))
- Scrub non-minidump attachments if there are explicit `$attachment` rules. ([#4415](https://github.com/getsentry/relay/pull/4415))

**Internal**:
Expand Down
8 changes: 4 additions & 4 deletions relay-event-schema/src/protocol/stacktrace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub struct Frame {
///
/// This function name may be shortened or demangled. If not, Sentry will demangle and shorten
/// it for some platforms. The original function name will be stored in `raw_function`.
#[metastructure(max_chars = 256, max_chars_allowance = 20)]
#[metastructure(max_chars = 512, max_chars_allowance = 20)]
#[metastructure(skip_serialization = "empty")]
pub function: Annotated<String>,

Expand All @@ -39,9 +39,9 @@ pub struct Frame {
///
/// The logic to be applied is that an intelligently trimmed function name should be stored in
/// `function` and the value before trimming is stored in this field instead. However also this
/// field will be capped at 256 characters at the moment which often means that not the entire
/// field will be capped at 512 characters at the moment which often means that not the entire
/// original value can be stored.
#[metastructure(max_chars = 256, max_chars_allowance = 20)]
#[metastructure(max_chars = 512, max_chars_allowance = 20)]
#[metastructure(skip_serialization = "empty")]
pub raw_function: Annotated<String>,

Expand All @@ -52,7 +52,7 @@ pub struct Frame {
/// like Swift, C++ or Rust.
// XXX(markus): How is this different from just storing the mangled function name in
// `function`?
#[metastructure(max_chars = 256)]
#[metastructure(max_chars = 512)]
pub symbol: Annotated<String>,

/// Name of the module the frame is contained in.
Expand Down

0 comments on commit 68788e0

Please sign in to comment.