Skip to content

Commit

Permalink
feat(metrics): Add span.system tag to span metrics (#3913)
Browse files Browse the repository at this point in the history
In anticipation of the new MongoDB support that is being added to the
Insights Queries module, this PR will add the `span.system` tag to
metrics. This will allow for querying all database systems in a
particular project, so that users can switch the view of the queries
module based on their choice of DBMS.
  • Loading branch information
0Calories authored Aug 9, 2024
1 parent 70c15da commit a4fd614
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Introduce `trim = "disabled"` type attribute to prevent trimming of spans. ([#3877](https://github.com/getsentry/relay/pull/3877))
- Make the tcp listen backlog configurable and raise the default to 1024. ([#3899](https://github.com/getsentry/relay/pull/3899))
- Extract `user.geo.country_code` into span indexed. ([#3911](https://github.com/getsentry/relay/pull/3911))
- Add `span.system` tag to span metrics ([#3913](https://github.com/getsentry/relay/pull/3913))

## 24.7.1

Expand Down
4 changes: 4 additions & 0 deletions relay-dynamic-config/src/defaults.rs
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,10 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
Tag::with_key("trace.status")
.from_field("span.sentry_tags.trace.status")
.when(is_queue_op.clone()),
// database module
Tag::with_key("span.system")
.from_field("span.sentry_tags.system")
.when(is_db.clone()),
],
},
TagMapping {
Expand Down
Loading

0 comments on commit a4fd614

Please sign in to comment.