Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Gather metrics for unprintable fields #1008

Merged
merged 4 commits into from
May 26, 2021
Merged

Conversation

Swatinem
Copy link
Member

We know that the native SDK, mostly in combination with Android can sometimes produce corrupted environment or release strings. We would like to get a measure of how bad this situation actually is.

This is an alternative to #994

We know that the native SDK, mostly in combination with Android can sometimes produce corrupted environment or release strings. We would like to get a measure of how bad this situation actually is.
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two suggestions below.

relay-server/src/actors/envelopes.rs Outdated Show resolved Hide resolved
relay-server/src/metrics.rs Outdated Show resolved Hide resolved
@Swatinem Swatinem requested a review from jan-auer May 21, 2021 20:55
* master:
  fix: Update manylinux regex for craft (#1005)
  fix(schema): Explicitly declare reprocessing context (#1009)
  feat(filter): Add safari-web-extension to known browser extensions (#1011)
  ref(log): Remove excessive info `done` log for each request (#1010)
  fix(server): Properly fuse shared payloads on error (#1007)
  fix: Update manylinux regex for craft
  release: 0.8.6
@jan-auer jan-auer enabled auto-merge (squash) May 26, 2021 10:43
@jan-auer jan-auer merged commit 60402a8 into master May 26, 2021
@jan-auer jan-auer deleted the feat/unprintable-server branch May 26, 2021 10:53
jan-auer added a commit that referenced this pull request May 27, 2021
* master:
  feat(server): Gather metrics for unprintable fields (#1008)
  fix: Update manylinux regex for craft (#1005)
  fix(schema): Explicitly declare reprocessing context (#1009)
  feat(filter): Add safari-web-extension to known browser extensions (#1011)
  ref(log): Remove excessive info `done` log for each request (#1010)
  fix: Update manylinux regex for craft
  release: 0.8.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants