fix(server): Validate release and environment attrs in sessions #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedetefy
reviewed
Jun 8, 2021
| @@ -468,3 +468,25 @@ def test_session_auto_ip(mini_sentry, relay_with_processing, sessions_consumer): | |||
| # Can't test ip_address since it's not posted to Kafka. Just test that it is accepted. | |||
| session = sessions_consumer.get_session() | |||
| assert session | |||
|
|
|||
|
|
|||
| def test_session_invalid_release(mini_sentry, relay_with_processing, sessions_consumer): | |||
There was a problem hiding this comment.
I would add a test_session_invalid_environment test here too
ahmedetefy
reviewed
Jun 8, 2021
| "sid": "8333339f-5675-4f89-a9a0-1c935255ab58", | ||
| "timestamp": timestamp.isoformat(), | ||
| "started": timestamp.isoformat(), | ||
| "attrs": {"release": "latest"}, |
There was a problem hiding this comment.
And maybe some tests for erroneous releases like the ones mentioned here -> https://github.com/getsentry/sentry/pull/26279/files#diff-21815168d041846d793a0e86869d5eb8391601025fb32017363e3359e93188b5R649
There was a problem hiding this comment.
Could do, but since this is in integration tests, I see little point in testing sentry-release-parser.
ahmedetefy
approved these changes
Jun 8, 2021
mitsuhiko
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates the
releaseandenvironmentattributes in sessions. Invalidreleases drop the session, since releases are required. Invalid environments are
simply removed.