-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(py): Build and publish arm64 wheels #1100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
commented
Oct 19, 2021
This reverts commit d17f360.
armenzg
approved these changes
Oct 19, 2021
jan-auer
commented
Oct 19, 2021
@@ -6,7 +6,7 @@ BUILD_DIR="/work" | |||
docker run \ | |||
-w /work/py \ | |||
-v `pwd`:/work \ | |||
quay.io/pypa/manylinux2010_${BUILD_ARCH} \ | |||
quay.io/pypa/${BUILD_ARCH} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved into build_library.yml
.
untitaker
approved these changes
Oct 19, 2021
untitaker
approved these changes
Oct 19, 2021
asottile-sentry
added a commit
that referenced
this pull request
May 18, 2022
looks like this was accidentally added in #1100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds builds for macOS and Linux arm64 wheels. The linux wheels are practically still manylinux_2010 compliant, however we're not able to build them as easily since there's no Docker container for that upstream.