fix(server): Finish decoding compressed requests correctly [INGEST-619] #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Nov 12, 2021
jan-auer
commented
Nov 12, 2021
| Ok(Async::NotReady) => return Ok(Async::NotReady), | ||
| Err(error) => return Err(error), | ||
| }; | ||
| loop { |
There was a problem hiding this comment.
This is the largest change. To summarize the diff:
- If the payload returns
None, finish the decoder. This may returnNoneagain or another chunk of bytes; both is fine at that point - If the decoder doesn't yield a result, continue looping to poll the next chunk
jan-auer
changed the title
Instructions and example for changelogFor changes exposed to the Python package, please add an entry to For changes to the Relay server, please add an entry to
To the changelog entry, please add a link to this PR (consider a more descriptive message): - Finish decoding compressed requests correctly [INGEST-619]. ([#1123](https://github.com/getsentry/relay/pull/1123))If none of the above apply, you can opt out by adding #skip-changelog to the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is required to finish decoders to flush remaining buffers and validate
checksums at the end of the payload. In this PR, we ensure this by replacing
Decoder::takewithDecoder::finish. Thetakemethod is now fully internaland only used in the streaming
DecodingPayload. All other users must callfinishinstead.