feat(outcomes): Aggregate more outcomes [INGEST-671] #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Nov 23, 2021
jan-auer
added a commit
that referenced
this pull request
Nov 24, 2021
* master: test(outcomes): Fix sort order in flaky test (#1135) feat(outcomes): Aggregate more outcomes (#1134) ref(outcomes): Fold processing vs non-processing into single actor (#1133) build: Update symbolic to support UE5 (#1132) feat(metrics): Extract measurement ratings, port from frontend (#1130) feat(metrics): Another statsd metric to measure bucket duplication (#1128) feat(outcomes): Emit outcomes as client reports (#1119) fix: Move changelog line to right version (#1129) fix(dangerjs): Do not suggest to add JIRA ticket to changelog (#1125) feat(metrics): Tag metrics by transaction name [INGEST-542] (#1126)
jjbayer
added a commit
that referenced
this pull request
Mar 26, 2024
#1134 introduced aggregation for most outcomes, but it did not include inbound filters. Outcomes are no longer used for investigating individual events, so we might as well save resources by aggregating all outcomes unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erase
event_idandremote_addrfrom the following outcomes, so that they can be efficiently aggregated.RateLimited(_): the biggest offenders are usage_exceeded and abuse, and in both cases we don't need outcomes to debug individual events.Invalid(ProjectId): this is easy to diagnose from other info and usually applies to all traffic, not individual events.FilteredSampling(_): is expected to create too much load when high-cardinality fields are preserved.