feat(metrics): Prefix all metric names [INGEST-548] #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Dec 6, 2021
| "sentry.transactions.measurements.lcp", | ||
| "sentry.transactions.breakdowns.breakdown1.bar", | ||
| "sentry.transactions.breakdowns.breakdown2.baz", | ||
| "sentry.transactions.breakdowns.breakdown2.zap" |
There was a problem hiding this comment.
I briefly considered omitting the prefixes in the project config, since we're already in a config object called transactionMetrics. But I figured that listing the full metric name would simplify searching for it, as with snuba referrers.
| @@ -115,7 +128,7 @@ pub fn extract_transaction_metrics( | |||
| }; | |||
|
|
|||
| push_metric(Metric { | |||
| name: format!("breakdown.{}.{}", breakdown, name), | |||
| name: metric_name(&["breakdowns", breakdown, name]), | |||
There was a problem hiding this comment.
Note that this renames metrics from breakdown.foo to breakdowns.foo, to be consistent with measurements.
untitaker
approved these changes
Dec 6, 2021
| fn metric_name(parts: &[&str]) -> String { | ||
| let mut name = METRIC_NAME_PREFIX.to_owned(); | ||
| for part in parts { | ||
| name = format!("{}.{}", name, part); |
There was a problem hiding this comment.
Suggested change
| name = format!("{}.{}", name, part); | |
| write!(".{}", part); |
this may need some bogus error-handling because it goes through io::Write, but it prevents string allocations
untitaker
approved these changes
Dec 7, 2021
jjbayer
added a commit
to getsentry/sentry
that referenced
this pull request
Dec 14, 2021
As in getsentry/relay#1147, prefix all metric names with either "sentry.sessions" or "sentry.transactions".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add product-specific prefixes to all metric names.
See also https://www.notion.so/sentry/Metrics-Namespaces-3679dfa27ed14b98975b154eb580644c.
This requires #1146 to be merged first.