ref(metrics): Refactor aggregation error, recover from errors more gracefully [ingest-1204] #1240
Conversation
| @@ -716,8 +716,26 @@ impl Bucket { | |||
|
|
|||
| /// Any error that may occur during aggregation. | |||
| #[derive(Debug, Fail)] | |||
| #[fail(display = "failed to aggregate metrics")] | |||
| pub struct AggregateMetricsError; | |||
| #[fail(display = "failed to aggregate metrics: {}", kind)] | |||
There was a problem hiding this comment.
nit: not sure how this composes outside, but you might be able to go without the prefix?
There was a problem hiding this comment.
I can do without prefix but then I need to put the prefix into the log message, otherwise the sentry errors just print "invalid character" without context
untitaker
changed the title
Instructions and example for changelogFor changes exposed to the Python package, please add an entry to For changes to the Relay server, please add an entry to
To the changelog entry, please add a link to this PR (consider a more descriptive message): - Refactor aggregation error, recover from errors more gracefully. ([#1240](https://github.com/getsentry/relay/pull/1240))If none of the above apply, you can opt out by adding #skip-changelog to the PR description. |
* master: fix: Add bucket key to extra (#1243) fix(metrics): Remove/reject nul-bytes from metric strings (#1235) chore: Bump sentry-release-parser (#1242) fix(metrics): Fix MRI validation in statsd protocol (#1241) ref(metrics): Refactor aggregation error, recover from errors more gracefully (#1240)
See discussion in #1235
This PR introduces variants to aggregation error, and skips over broken buckets instead of dropping the entire batch.