fix(metrics): Introduce revisions for metrics extraction [INGEST-1303] #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With moving to MRIs, we have changed the names of extracted session
metrics. At the time, this was guarded behind a feature flag, but this
feature flag was also propagated to external Relays. There is a range of
Relay versions that recognize the feature flag but do not implement the
proper MRI schema.
This PR changes the configuration schema and deprecates the feature
flag. The new config includes a version counter, currently set at
1,which only Relays with the correct MRIs recognize now.
Following the deployment, the feature flag will be disabled, so that
outdated Relays no longer extract session metrics. Requires
getsentry/sentry#34103