fix(server): Update fields in LimitedProjectConfig [INGEST-1303] #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Apr 29, 2022
| @@ -142,9 +142,15 @@ pub struct LimitedProjectConfig { | |||
| pub allowed_domains: Vec<String>, | |||
| pub trusted_relays: Vec<PublicKey>, | |||
| pub pii_config: Option<PiiConfig>, | |||
| #[serde(skip_serializing_if = "DataScrubbingConfig::is_disabled")] | |||
There was a problem hiding this comment.
there is a remote derive for ProjectConfig on this struct. Are you sure those things are needed here?
There was a problem hiding this comment.
nevermind, I think this makes sense after re-reading how remote works
There was a problem hiding this comment.
I'm not sure, but it looks to me like an oversight. I will definitely add more tests at a later point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the recently added
session_metricsfield toLimitedProjectConfig, which allows this field to be exposed tountrusted Relays. In addition to that, this PR adds serde's
skip_serializing_ifdirective to skip empty fields in the reducedproject config format.