feat(dynamic_samping): Adjust sample rate by envelope header's sample_rate [INGEST-1395] #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Jun 30, 2022
| "user_id": "hello" | ||
| } | ||
| "###); | ||
| } |
There was a problem hiding this comment.
Should we test this with some more values for sample_rate? E.g. "bogus", "10e4", ...
There was a problem hiding this comment.
Can we also add a test for a negative sample_rate?
jjbayer
approved these changes
Jun 30, 2022
jan-auer
reviewed
Jun 30, 2022
|
@jan-auer okay, I addressed half of the review comments. I am not acting on two things in this PR:
I think the PR as-is gets us quite far already. It doesn't make the existing problem of double-sampling worse, and we can run demos in prod as long as we point SDKs to the apex domain. |
iker-barriocanal
previously requested changes
Jul 1, 2022
| "user_id": "hello" | ||
| } | ||
| "###); | ||
| } |
There was a problem hiding this comment.
Can we also add a test for a negative sample_rate?
Co-authored-by: Iker Barriocanal <[email protected]>
iker-barriocanal
dismissed
their stale review
Removing my blocker, division by 0 doesn't panic with floats.
Co-authored-by: Iker Barriocanal <[email protected]>
jan-auer
approved these changes
Jul 4, 2022
Co-authored-by: Jan Michael Auer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a new envelope header that tells us the configured sample rate of the client that initiated the trace. Adjust trace sampling by that incoming sample rate.
TODO: