feat(metrics): Drop transaction tag for high-cardinality sources [INGEST-1437] #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Jul 13, 2022
| tags.insert("transaction".to_owned(), transaction.to_owned()); | ||
| if keep_transaction_name(event.get_transaction_source()) { | ||
| tags.insert("transaction".to_owned(), transaction.to_owned()); | ||
| } |
There was a problem hiding this comment.
This unconditionally drops the transaction name for certain transaction sources. I have considered making this configurable, or even putting it in project config, but decided that that would be overkill at the moment.
| // Any other value would be an SDK bug, assume high-cardinality and drop. | ||
| TransactionSource::Other(source) => { | ||
| // EnvelopeProcessor sets project and SDK on the scope, so no need to add sentry tags here. | ||
| relay_log::error!("Invalid transaction source: '{}'", source); |
There was a problem hiding this comment.
Not sure if it really makes sense to log an error here. If an SDK adds a transaction source deliberately, we will have to ignore this error until Relay updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the
transactiontag for metrics extracted from transaction payload if the transaction source isurlorunknown, because these might contain identifiers that blow up the number of different metrics buckets.Note that this leads to differences between the transactions dataset and the metrics dataset, which the product will have to handle.