feat(normalization): Write default transaction source [INGEST-1511] #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
requested review from
a team,
bitsandfoxes,
k-fish and
jan-auer
and removed request for
bitsandfoxes
untitaker
approved these changes
Jul 28, 2022
…1356) Excludes more SDKs from transaction name extraction that are known to contain bad URLs.
jan-auer
approved these changes
Jul 28, 2022
* master: fix(metrics): Fix broken extraction of ops breakdown and conditional tagging (#1357) fix(unreal): Don't drop event in PoP relays [INC-181] [ISSUE-1558] (#1355)
tobias-wilfert
pushed a commit
that referenced
this pull request
Aug 9, 2022
In #1354, we introduced behavior that wrote back the default transaction source (unknown) into the event during normalization. Unfortunately, since the default qualifies as empty, this value was still not serialized into the event payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For old SDK that do not yet send an
event.transaction_info.sourcevalue, write the default "unknown" to the transaction payload.For a specific group of SDKs that we expect to send many distinct transaction names (containing identifiers), omit the default, such that these transactions can be queried for explicitly in the product.