fix(profiling): Re-encode the Typescript payload to normalize #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Aug 2, 2022
Zylphrex
approved these changes
Aug 2, 2022
phacops
deleted the
pierre/profiling-reencode-the-typescript-payload-to-normalize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, if we could parse the Typescript payload, we would forward it as is to the rest of the pipeline.
Since we're normalizing it (converting uint64 sent as strings to a
u64type for example), we need to re-encode it in JSON and then forward it otherwise the payload will not be normalized as we expect.This PR fixes this issue. I also removed test files that were moved to the
relay-profilingcrate but not deleted from therelay-servercrate.