fix(http): Explain why we responded with 429 #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix getsentry/sentry#37103 Oftentimes we are not in control of the rate limit response, but if we are, we can provide a more helpful error message. The context here is that a customer was confused about whether the network errors in Chrome's dev console would have any impact on their application. While we can't influence the color of what is shown in the dev console, we can provide documentation links in request/response details. This will still be quite hidden but better than nothing. Other ideas were to stop emitting 429s, but we could only do that for browser, mobile and other "client" SDKs. For server-side SDKs we _need_ them to see a 429 so they stop sending data. And even then that change would come with high risk of multiplying inbound traffic by a large factor.
flub
approved these changes
Aug 8, 2022
jjbayer
approved these changes
Aug 9, 2022
Co-authored-by: Joris Bayer <[email protected]>
iker-barriocanal
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix getsentry/sentry#37103
Oftentimes we are not in control of the HTTP response (load balancers and relay may reject the request for a variety of reasons, and it would probably be quite a bit of effort to add docs links to all of those return paths), but if we
are, we can provide a more helpful error message.
The context here is that a customer was confused about whether the
network errors in Chrome's dev console would have any impact on their
application. While we can't influence the color of what is shown in the
dev console, we can provide documentation links in request/response
details. This will still be quite hidden but better than nothing.
Other ideas were to stop emitting 429s, but we could only do that for
browser, mobile and other "client" SDKs. For server-side SDKs we need
them to see a 429 so they stop sending data. And even then that change
would come with high risk of multiplying inbound traffic by a large
factor.