Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(normalization): Use correct meta object for logentry in light normalization [INGEST-1679] #1577

Merged
merged 3 commits into from
Nov 11, 2022
Merged

fix(normalization): Use correct meta object for logentry in light normalization [INGEST-1679] #1577

merged 3 commits into from
Nov 11, 2022

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Nov 11, 2022

This PR fixes bug for log entry light normalization, where we used wrong level meta object for errors annotations.

@olksdr olksdr self-assigned this Nov 11, 2022
@olksdr olksdr requested a review from a team November 11, 2022 06:50
jjbayer
jjbayer approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! On the invalid-transaction.json payload, is the diff with the version before light normalization now empty?

@olksdr
Copy link
Contributor Author

olksdr commented Nov 11, 2022 •
edited
Loading

Looks good to me! On the invalid-transaction.json payload, is the diff with the version before light normalization now empty?

So now we have again the errors populated and _meta in the correct place, like it was before.

image

See screenshot , left side it the old before light normalization, and on the right side is the latest revision with this fix.

@olksdr olksdr merged commit 2faa33d into master Nov 11, 2022
@olksdr olksdr deleted the fix/logentry-error branch November 11, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees

@olksdr olksdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olksdr @jjbayer