Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(general): Permit invalid emails in user interface #161

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

jan-auer
Copy link
Member

Permits any value as user.email, which is required for PII stripped events. This changes the behavior from current Python.

@jan-auer jan-auer self-assigned this Jan 22, 2019
@jan-auer jan-auer requested a review from untitaker January 22, 2019 14:33
@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #161 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   63.59%   63.54%   -0.05%     
==========================================
  Files          82       82              
  Lines        8738     8724      -14     
==========================================
- Hits         5557     5544      -13     
+ Misses       3181     3180       -1
Impacted Files Coverage Δ
general/src/protocol/user.rs 100% <ø> (ø) ⬆️
general/src/store/mod.rs 80% <ø> (-10%) ⬇️
general/src/store/schema.rs 99.1% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a44aa...43e40a9. Read the comment docs.

@jan-auer
Copy link
Member Author

Blocked on getsentry/sentry#11644

@jan-auer jan-auer merged commit bc420bc into master Jan 22, 2019
@jan-auer jan-auer deleted the ref/email-regex branch January 22, 2019 20:06
jan-auer added a commit that referenced this pull request Jan 23, 2019
* master:
  feat: update insta
  ref(general): Permit invalid emails in user interface (#161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants