Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replays): Scrub PII from texts mutation nodes #1796

Merged
merged 5 commits into from
Jan 31, 2023
Merged

feat(replays): Scrub PII from texts mutation nodes #1796

merged 5 commits into from
Jan 31, 2023

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jan 30, 2023 •
edited
Loading

  • Adds support for PII scrubbing the "texts" vector on the incremental mutation source struct.
  • Adds coverage for this usecase.
  • Improves coverage for existing cases.

@cmanallen cmanallen requested a review from a team January 30, 2023 20:30
@jan-auer jan-auer enabled auto-merge (squash) January 31, 2023 09:02
@jan-auer jan-auer merged commit 961b1a8 into master Jan 31, 2023
@jan-auer jan-auer deleted the replays-parse-texts-mutation branch January 31, 2023 09:18
jan-auer added a commit that referenced this pull request Jan 31, 2023
@jan-auer
Merge branch 'master' into replays-remove-uses-of-value-type
df28fde 
* master:
  feat(replays): Scrub PII from texts mutation nodes (#1796)
  chore(replays): Restructure scrubbing log output to be more readable in console (#1794)
  bug(replays): Allow null category field in breadcrumb payload (#1795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmanallen @jan-auer