fix(txnames): Avoid replacing url encoded transaction names #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Feb 10, 2023
jjbayer
reviewed
Feb 10, 2023
…ntry/relay into fix/do-not-match-urlencoded-string
jan-auer
changed the title
jan-auer
reviewed
Feb 10, 2023
jjbayer
approved these changes
Feb 13, 2023
| .to_string(); | ||
| if *trans != changed && changed != "*" { | ||
| // Sort by the longest match end. | ||
| caps.sort_by_key(|(m, _)| m.end()); |
There was a problem hiding this comment.
nit: Rename m to match everywhere?
There was a problem hiding this comment.
match is actually the reserved word 😄. But I also can change it to capture, since it's basically what it is. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified regex to avoid replacing url encoded strings, this way if there are something like
%[A-F0-9]in the string, we will skip replacing it, since we do track only the named captures./cc @jan-auer
fix: https://github.com/getsentry/team-ingest/issues/56
#skip-changelog