feat(monitors): Pass environment through #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-monitors-pass-environment-through
branch
from
74583f4 to
7b695d9
Compare
olksdr
approved these changes
Apr 13, 2023
iker-barriocanal
approved these changes
Apr 13, 2023
Comment on lines
+116
to
+118
| /// The environment to associate the check-in with | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| environment: Option<String>, |
There was a problem hiding this comment.
Let's add some length limits to this string, like here. Monitor slugs may contain non-ASCII characters, if this isn't the case for environment consider also adding allow_chars.
There was a problem hiding this comment.
Sounds good. Thanks for linking this
There was a problem hiding this comment.
Actually, it looks like events uses a completely separate serialization system? I'm not familiar with metastructure
There was a problem hiding this comment.
Going to merge this as is and revisit validation
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-monitors-pass-environment-through
branch
from
7b695d9 to
25c88a0
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-monitors-pass-environment-through
branch
from
25c88a0 to
8f82ef1
Compare
evanpurkhiser
deleted the
evanpurkhiser/feat-monitors-pass-environment-through
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports specifying the checkins environment