feat(replays): lower max replay recording segment size to 10 MiB

CHANGELOG.md

@@ -23,6 +23,10 @@ Metrics:
 - The `route` tag of request metrics uses the route pattern instead of schematic names. There is an exact replacement for every previous route. For example, `"store-default"` is now tagged as `"/api/:project_id/store/"`.
 - Statsd metrics `event.size_bytes.raw` and `event.size_bytes.uncompressed` have been removed.
 
+Replays:
+
+- Lower max compressed replay recording segment size to 10 MiB. ([#2031](https://github.com/getsentry/relay/pull/2031))
+
 **Features**:
 
 - Allow monitor checkins to paass `monitor_config` for monitor upserts. ([#1962](https://github.com/getsentry/relay/pull/1962))

relay-config/src/config.rs

@@ -542,8 +542,10 @@ struct Limits {
     max_api_chunk_upload_size: ByteSize,
     /// The maximum payload size for a profile
     max_profile_size: ByteSize,
-    /// The maximum payload size for a replay.
-    max_replay_size: ByteSize,
+    /// The maximum payload size for a compressed replay.
+    max_replay_compressed_size: ByteSize,
+    /// The maximum payload size for an uncompressed replay.
+    max_replay_uncompressed_size: ByteSize,
     /// The maximum number of threads to spawn for CPU and web work, each.
     ///
     /// The total number of threads spawned will roughly be `2 * max_thread_count + 1`. Defaults to
@@ -577,7 +579,8 @@ impl Default for Limits {
             max_api_file_upload_size: ByteSize::mebibytes(40),
             max_api_chunk_upload_size: ByteSize::mebibytes(100),
             max_profile_size: ByteSize::mebibytes(50),
-            max_replay_size: ByteSize::mebibytes(100),
+            max_replay_compressed_size: ByteSize::mebibytes(10),
+            max_replay_uncompressed_size: ByteSize::mebibytes(100),
             max_thread_count: num_cpus::get(),
             query_timeout: 30,
             shutdown_timeout: 10,
@@ -1822,9 +1825,14 @@ impl Config {
         self.values.limits.max_profile_size.as_bytes()
     }
 
-    /// Returns the maximum payload size for a replay.
-    pub fn max_replay_size(&self) -> usize {
-        self.values.limits.max_replay_size.as_bytes()
+    /// Returns the maximum payload size for an compressed replay.
+    pub fn max_replay_compressed_size(&self) -> usize {
+        self.values.limits.max_replay_compressed_size.as_bytes()
+    }
+
+    /// Returns the maximum payload size for an uncompressed replay.
+    pub fn max_replay_uncompressed_size(&self) -> usize {
+        self.values.limits.max_replay_uncompressed_size.as_bytes()
     }
 
     /// Returns the maximum number of active requests

relay-server/src/actors/processor.rs

@@ -1134,7 +1134,7 @@ impl EnvelopeProcessorService {
         let client_addr = meta.client_addr();
         let event_id = state.envelope().event_id();
 
-        let limit = self.config.max_replay_size();
+        let limit = self.config.max_replay_uncompressed_size();
         let config = project_state.config();
         let datascrubbing_config = config
             .datascrubbing_settings

relay-server/src/utils/sizes.rs

@@ -32,13 +32,18 @@ pub fn check_envelope_size_limits(config: &Config, envelope: &Envelope) -> bool
             | ItemType::FormData => {
                 event_size += item.len();
             }
-            ItemType::Attachment | ItemType::UnrealReport | ItemType::ReplayRecording => {
+            ItemType::Attachment | ItemType::UnrealReport => {
                 if item.len() > config.max_attachment_size() {
                     return false;
                 }
 
                 attachments_size += item.len()
             }
+            ItemType::ReplayRecording => {
+                if item.len() > config.max_replay_compressed_size() {
+                    return false;
+                }
+            }
             ItemType::Session | ItemType::Sessions => {
                 session_count += 1;
             }