ref(dynamic-sampling): Split function for sampling match

[iambriccardo]

This PR is a preparation for the refactoring of dynamic sampling. It contains the splitting of the matching function in order to decouple ProjectState and SamplingConfig.

[iker-barriocanal]

Thank you for taking the time to improve the code quality, and splitting up the original PR!

Please see the comment on the pub before merging, and consider continuing the refactor in follow-up PRs.

[iker-barriocanal]

If you think about the semantical usage of this function, there're two steps that we're doing here. It'd be great if we could split this function into the merging and matching functions. Could we do this in a follow-up PR?

[iambriccardo]

Ehm, they are already split up in lines 66 and 67. This function orchestrates their behavior, this is why it is named like this.

[iker-barriocanal]

I was thinking something like the following:

fn get_sampling_match() {
  merge_configs();
  match_configs();
}

[iambriccardo]

I don't think that the complexity of the code requires the creation of a third function encapsulating that behavior. If it was more complex I would have agreed. On the other hand, if the encapsulation follows some strict Relay guidelines I am happy to adapt.