Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profiling): Reject profiles longer than 30s #2168

Merged
merged 9 commits into from
Jun 2, 2023
Merged

feat(profiling): Reject profiles longer than 30s #2168

merged 9 commits into from
Jun 2, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented May 31, 2023

No description provided.

@phacops phacops requested a review from a team as a code owner May 31, 2023 15:02
@phacops phacops requested a review from a team May 31, 2023 15:03
Zylphrex
Zylphrex approved these changes May 31, 2023
View reviewed changes
relay-profiling/src/sample.rs Outdated Show resolved Hide resolved
@JonasBa
Copy link
Member

JonasBa commented May 31, 2023

sad

jjbayer
jjbayer approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There's already a bunch of unit tests in this file, you could copy-paste one to verify the new behavior.

relay-profiling/src/lib.rs Outdated Show resolved Hide resolved
relay-profiling/src/sample.rs Outdated Show resolved Hide resolved
@phacops phacops merged commit ed39746 into master Jun 2, 2023
@phacops phacops deleted the pierre/profiling-reject-profiles-longer-than-30-seconds branch June 2, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phacops @JonasBa @jjbayer @Zylphrex