feat(inbound filters): Add file:/// url to localhost inbound filter
#2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
changed the title
file:/// url to localhost inbound filterfile:/// url to localhost inbound filter
lobsterkatie
force-pushed
the
kmclb-add-file-url-filter
branch
3 times, most recently
from
171f4f1 to
fc991eb
Compare
lobsterkatie
force-pushed
the
kmclb-add-file-url-filter
branch
from
fc991eb to
c4e2bfb
Compare
jjbayer
approved these changes
Jun 14, 2023
relay-filter/src/localhost.rs
Outdated
| @@ -25,6 +25,9 @@ pub fn matches(event: &Event) -> bool { | |||
| } | |||
| } | |||
| } | |||
| if url.as_str().starts_with("file://") { | |||
There was a problem hiding this comment.
Suggested change
| if url.as_str().starts_with("file://") { | |
| if url.scheme() == "file" { |
lobsterkatie
force-pushed
the
kmclb-add-file-url-filter
branch
from
c4e2bfb to
180951d
Compare
lobsterkatie
force-pushed
the
kmclb-add-file-url-filter
branch
from
180951d to
f3dc2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a filter for events whose
urlvalue starts withfile://to the existing localhost inbound filter, as such events similarly represent errors on pages opened locally.Ref: getsentry/sentry#49519