fix(crons): Limit environment names on check-ins to 64 chars

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Add support for `sampled` field in the DSC and error tagging. ([#2290](https://github.com/getsentry/relay/pull/2290))
 - Move span tag extraction from metrics to normalization. ([#2304](https://github.com/getsentry/relay/pull/2304))
+- Limit environment names on check-ins to 64 chars. ([#2309](https://github.com/getsentry/relay/pull/2309))
 
 ## 23.6.2
 

relay-monitors/Cargo.toml

@@ -11,6 +11,7 @@ publish = false
 
 [dependencies]
 relay-common = { path = "../relay-common" }
+relay-general = { path = "../relay-general" }
 serde = { version = "1.0.114", features = ["derive"] }
 serde_json = "1.0.55"
 regex = "1.9.1"

relay-monitors/src/lib.rs

@@ -22,6 +22,9 @@ use serde::{Deserialize, Serialize};
 /// Maximum length of monitor slugs.
 const SLUG_LENGTH: usize = 50;
 
+/// Maximum length of environment names.
+const ENVIRONMENT_LENGTH: usize = MaxChars::Environment.limit();
+
 /// Error returned from [`process_check_in`].
 #[derive(Debug, thiserror::Error)]
 pub enum ProcessCheckInError {
@@ -32,6 +35,10 @@ pub enum ProcessCheckInError {
     /// Monitor slug was empty after slugification.
     #[error("the monitor slug is empty or invalid")]
     EmptySlug,
+
+    /// Environment name was invalid.environment.
+    #[error("the environment is invalid")]
+    InvalidEnvironment,
 }
 
 ///
@@ -160,6 +167,10 @@ pub fn process_check_in(payload: &[u8]) -> Result<Vec<u8>, ProcessCheckInError>
         return Err(ProcessCheckInError::EmptySlug);
     }
 
+    if check_in.environment.chars().count() > ENVIRONMENT_LENGTH {
+        return Err(ProcessCheckInError::InvalidEnvironment);
+    }
+
     Ok(serde_json::to_vec(&check_in)?)
 }
 
@@ -285,4 +296,20 @@ mod tests {
         let result = process_check_in(json.as_bytes());
         assert!(matches!(result, Err(ProcessCheckInError::EmptySlug)));
     }
+
+    #[test]
+    fn process_invalid_environment() {
+        let json = r#"{
+          "check_in_id": "a460c25ff2554577b920fcfacae4e5eb",
+          "monitor_slug": "test",
+          "status": "in_progress"
+          "environment": "1234567890123456789012345678901234567890123456789012345678901234567890"
+        }"#;
+
+        let result = process_check_in(json.as_bytes());
+        assert!(matches!(
+            result,
+            Err(ProcessCheckInError::InvalidEnvironment)
+        ));
+    }
 }