fix(server): Immediatly set global config to watch contents. #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
approved these changes
Sep 12, 2023
jan-auer
approved these changes
Sep 12, 2023
|
Please update the docs on |
olksdr
approved these changes
Sep 12, 2023
Comment on lines
+91
to
+93
| /// fails. Subscribers should use the initial value when they get the watch | ||
| /// rather than only waiting for the watch to update, in case a global config | ||
| /// is only updated once, such as is the case with the static config file. |
There was a problem hiding this comment.
Should we add a code example?
jan-auer
added a commit
that referenced
this pull request
Sep 13, 2023
* master: fix(server): Immediatly set global config to watch contents. (#2505) feat(server): Use global config from file if provided (#2458) ref(metrics): Remove deprecated `Metric` type and improve docs (#2503) ref(projconfig): Unsupport v4 in the endpoint (#2500) docs(dashboard): Add instructions for required WASM target (#2502) release: 0.8.30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envelopeprocessorservice updated the global config only when the watch changed, however, if we use static config then the watch won't change after we first set its contents to the static config. If we subscribe after it was first set, we wouldn't ever get to use the static config in the envelope processor service.
to fix this, we immediatly update the global config in envelope processor service to the contents of the watch.
#skip-changelog