feat(spans): Filter spans based on module #2511
Conversation
relay-dynamic-config/src/defaults.rs
Outdated
| "ui.*".into(), | ||
| "browser.*".into(), | ||
| "http.*".into(), | ||
| "grouping".into(), |
There was a problem hiding this comment.
@AbhiPrasad Can you validate these are the right values for the browser module? Maybe it should be without dots?
There was a problem hiding this comment.
The values should as per https://develop.sentry.dev/sdk/performance/span-operations/, there are some example span ops in there as well.
relay-server/src/actors/processor.rs
Outdated
| let span_op_db_module_denylist: HashSet<String> = HashSet::from([ | ||
| "db.clickhouse".into(), | ||
| "db.redis".into(), | ||
| "db.sql.query".into(), | ||
| ]); | ||
| let span_op_browser_module_prefix_allowlist: Vec<String> = vec![ | ||
| "browser".into(), | ||
| "http".into(), | ||
| "resource".into(), | ||
| "ui".into(), | ||
| ]; |
There was a problem hiding this comment.
Since these don't change during execution, what do you think about making them static and wrapping them in OnceCell? See another example in Relay.
relay-dynamic-config/src/defaults.rs
Outdated
| value: GlobPatterns::new(vec
relay-dynamic-config/src/defaults.rs
Outdated
| value: Value::Array(vec
|
I ended up simplifying into 2 groups: GA and all modules. We'll keep the filtering in Relay for the GA case and accepts all spans for projects in the allowlist. |
Co-authored-by: Jan Michael Auer <[email protected]>
We're trying to filter spans based on the
opfield as we prepare to ingest spans for GA. Due to the high cardinality of groupings, we would like to be selective on what we ingest.At first, we'd want to ingest spans for our DB and Browser modules. If the feature is enabled for the project, we'd add the necessary conditions to match spans corresponding to
opwe're interesting in.If no module is enabled, we ingest all spans.