Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crash): Fix the crash-handler feature #2532

Merged
merged 4 commits into from
Sep 25, 2023
Merged

fix(crash): Fix the crash-handler feature #2532

merged 4 commits into from
Sep 25, 2023

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Sep 25, 2023 •
edited
Loading

Repairs the crash handler feature, which was effectively disabled in recent builds.

  • Internal feature flagging was broken, and for this reason the functionality was never active when the feature flag was enabled.
  • Handling of envelopes from the native crash reporter was broken so that they could not be uploaded.
  • The configured environment was not used for native crashes.

olksdr
olksdr approved these changes Sep 25, 2023
View reviewed changes
relay-log/Cargo.toml Outdated Show resolved Hide resolved
@jan-auer jan-auer self-assigned this Sep 25, 2023
@jan-auer jan-auer marked this pull request as ready for review September 25, 2023 12:48
@jan-auer jan-auer requested a review from a team September 25, 2023 12:48
@jan-auer jan-auer enabled auto-merge (squash) September 25, 2023 13:21
@jan-auer jan-auer merged commit 37c5973 into master Sep 25, 2023
@jan-auer jan-auer deleted the fix/crash-handler branch September 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @olksdr