ref(spans): Scrub data image descriptions #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In span descriptions fetching encoded data images, the actual encoded image provides no value to the span. However, the number of `/`s is forcing the span description clusterer to misbehave.
iker-barriocanal
commented
Oct 3, 2023
Comment on lines
+376
to
+378
| "GET data:image/png;base64,drtfghaksjfdhaeh/blah/blah/blah", | ||
| "http.client", | ||
| "GET data:image/*" |
There was a problem hiding this comment.
We can relax the scrubbing to include png or base64, but I don't think it provides any value and complicates a bit the logic.
olksdr
approved these changes
Oct 3, 2023
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| **Features**: | |||
|
|
|||
| - Scrub span descriptions with encoded data images. ([#2560](https://github.com/getsentry/relay/pull/2560)) | |||
There was a problem hiding this comment.
I would omit this changelog records to be honest. And it's not really a feature in my opinion, maybe something like internal fits better here.
There was a problem hiding this comment.
Initially, I was planning to omit it. I saw the changelog section in the README and some scrubbing related entries in both features and internal. Since this is user-visible I'll leave it under features, unless someone strongly disagrees.
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - Scrub span descriptions with encoded data images. ([#2560](https://github.com/getsentry/relay/pull/2560)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In span descriptions fetching encoded data images, the actual encoded image provides no value to the span. However, the number of
/s is forcing the span description clusterer to misbehave.Resolves https://github.com/getsentry/team-ingest/issues/221.