Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Bind exclusively to the port #2582

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix(server): Bind exclusively to the port #2582

merged 2 commits into from
Oct 11, 2023

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Oct 10, 2023 •
edited
Loading

Bind eagerly (and exclusively) to the port for the HTTP server, and fail to start the Relay otherwise.

The proper error should be also provided, e.g.

ERROR relay_server::actors::server: Failed to start the HTTP server: Address already in use (os error 48)

fix #2423

#skip-changelog

@olksdr olksdr self-assigned this Oct 10, 2023
@olksdr olksdr requested a review from a team October 10, 2023 07:42
iker-barriocanal
iker-barriocanal approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we also had a test for this!

@olksdr olksdr merged commit 4c0acae into master Oct 11, 2023
@olksdr olksdr deleted the fix/bind-to-socket-exclusively branch October 11, 2023 13:13
@tuky
Copy link

tuky commented Oct 12, 2023

thx a lot! will try it soon in our setup using AWS AppRunner!

@tuky
Copy link

tuky commented Oct 17, 2023

Yes, it works again 🎉 I could successfully launch a nightly image from 5 days ago to AWS AppRunner.

@olksdr
Copy link
Contributor Author

olksdr commented Oct 17, 2023

@tuky, great! Thanks for reporting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Assignees

@olksdr olksdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not properly binding the port since 23.4.0 (therefore unable to deploy to AWS app runner)
3 participants
@olksdr @tuky @iker-barriocanal