Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Restrict resource spans to script, css and link #2623

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 17, 2023

This will restrict to only resource.script, resource.css and resource.link span ops.

@phacops phacops requested a review from jjbayer October 17, 2023 23:17
@phacops phacops marked this pull request as ready for review October 17, 2023 23:17
@phacops phacops requested a review from a team October 17, 2023 23:17
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are some failing tests, but overall LGTM

@phacops phacops changed the title fix(spans): Restrict resource spans to script and css fix(spans): Restrict resource spans to script, css and link Oct 18, 2023
@phacops phacops merged commit 163dc87 into master Oct 18, 2023
@phacops phacops deleted the pierre/spans-restrict-resource-spans-to-script-css branch October 18, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants