feat(app-start): Add Android app start-related spans #2927
Conversation
These spans are nested operations under the app.start.* spans on Android. Start collecting them for the Sentry product so we have some data before moving into the default config.
| @@ -82,6 +82,26 @@ pub(crate) fn scrub_span_description(span: &Span) -> Option<String> { | |||
| // They are low-cardinality. | |||
| Some(description.to_owned()) | |||
| } | |||
| ("contentprovider", "load") => { | |||
There was a problem hiding this comment.
@jjbayer You pointed me to this file initially, is this the only change I need to make to have these new span ops ingested internally?
There was a problem hiding this comment.
You'll also want to extend the MOBILE_OPS constant in defaults.rs:
relay/relay-dynamic-config/src/defaults.rs
Lines 20 to 21 in 7606bce
There was a problem hiding this comment.
Sounds good, I was thinking about doing that but I was worried adding the entry to default.rs would enable it incorrectly for all orgs. I've added them now and also regenerated some snapshots with these new ops
There was a problem hiding this comment.
That is a good point! I just merged #2924, so the Feature::SpanMetricsExtractionAllModules flag and only extend the mobile ops conditionally.
|
@jjbayer Just a heads up I've addressed your comment in this PR and implemented the change we discussed to update the mobile ops conditionally. Totally open to seeing alternative implementations if you have suggestions on how to do this part better, but I found a way to do it in a single block 👍 |
@narsaynorath looks good to me. There's definitely a way to do it with iterator chaining, but IMO not worth the effort and it would not increase readability. |
These spans are nested operations under the app.start.* spans on Android. Start collecting them for the Sentry product so we have some data before moving into the default config.
Note: This only adds the application portion of the spans. We are currently awaiting a new span that tracks the system portion of the app start and I will add that as another span op afterwards.
These spans are listed out here for further information: