Forward profiles of non-sampled transactions #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us use data of non sampled profiles to enhance current aggregation (slowest function) with more data.
…ng (#2383) Updating the envelope summary during envelope processing is currently a no-go, because recomputing the summary will miss the event item, which is taken from the envelope before processing. #2380 contains an attempt to remove caching of the envelope summary entirely. As a quick fix, this PR provides a partial update function. #skip-changelog
…into ref/processing-pre-item
viglia
approved these changes
Jan 24, 2024
jjbayer
commented
Jan 25, 2024
jjbayer
commented
Jan 25, 2024
Dav1dde
reviewed
Jan 25, 2024
Dav1dde
approved these changes
Jan 25, 2024
Dav1dde
approved these changes
Jan 26, 2024
Co-authored-by: Iker Barriocanal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowest function aggregation is a metrics-like profiling feature that requires symbolicated frames. Because of this dependency, it cannot (yet) be implemented as metrics aggregation in relay. Instead, forward all profiles to sentry, even if they would otherwise be dropped by dynamic sampling.
This feature is still experimental and guarded by a feature flag + global options.
This PR replaces #2374.