feat(inbound-filters): Create new legacy browser filters #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@getsentry/ingest let me know your thoughts on this pr! was going off of previous PRs that added new filters since this isn't my area of expertise. One question I have: Is it safe to merge this before any of the |
jjbayer
reviewed
Jan 19, 2024
There was a problem hiding this comment.
This looks good to me, @roggenkemper would you mind adding some tests? There should be some you can copy-paste in legacy_browsers.rs.
That should be safe AFAIK. |
jjbayer
approved these changes
Jan 23, 2024
Co-authored-by: Joris Bayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds in new legacy browser filters. These new filters will be more up to date than the existing ones, and would allow for easier updates to the filters if needed. right now, the filters are defined as both a browser and a version ("safari_pre_6"). now the filters will just be for a browser, and we will have easier control over what versions to filter- we no longer have to make a new filter, we can just update what values get filtered. this can both be a short term and longer term fix to the problem with legacy browsers. It will allow us to move over to new filters in the short term, while supporting updates in the long term if needed (since the generic filters project doesn't have a timeline right now).
closes getsentry/sentry#63053