fix: Process user reports in separate group #2981
Conversation
|
@JoshFerge thanks for testing this! |
| @@ -192,6 +192,17 @@ impl ProcessingGroup { | |||
| )) | |||
| } | |||
|
|
|||
| // Extract user report and user feedback. | |||
| let report_items = envelope.take_items_by(|item| { | |||
| matches!(item.ty(), &ItemType::UserReport | &ItemType::ClientReport) | |||
There was a problem hiding this comment.
Client reports are very different from user reports: They carry outcomes, so like metrics they can be processed either completely separately or in a common envelope with other ungrouped items.
The similarity in the name ClientReport and UserReport is merely coincidental.
| @@ -192,6 +192,17 @@ impl ProcessingGroup { | |||
| )) | |||
| } | |||
|
|
|||
| // Extract user report and user feedback. | |||
| let report_items = envelope.take_items_by(|item| { | |||
| matches!(item.ty(), &ItemType::UserReport | &ItemType::ClientReport) | |||
There was a problem hiding this comment.
User reports are items that require event payloads, hence should be processed in the same group as attachments (or standalone attachments). We should follow up with refactoring the standalone attachment group above (really the "doesn't have an event"-group) to cover all items that have requires_event set to true.
Note that the requires_event flag means that these items are existentially bound to an event instance in Sentry. That's the reason they are grouped together with events: If the event is dropped, so will be the other items. However, that doesn't mean the event payload must be in the same envelope. We should verify that the other pipelines handle that correctly.
Process user reports in separate processing group.
Related #2980