Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(cardinality): Use cardinality limits from project config #2990

Merged
merged 2 commits into from
Jan 25, 2024
Merged

ref(cardinality): Use cardinality limits from project config #2990

merged 2 commits into from
Jan 25, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Jan 23, 2024 •
edited
Loading

Reads the cardinality config from the project config instead of generating them from the Relay config.

Sentry side implemented in: getsentry/sentry#63562

@Dav1dde Dav1dde force-pushed the dav1d/cardinality-from-project-config branch from 3423877 to f4f62df Compare January 23, 2024 13:21
@Dav1dde Dav1dde self-assigned this Jan 23, 2024
@Dav1dde Dav1dde force-pushed the dav1d/cardinality-from-project-config branch from f4f62df to 5622129 Compare January 23, 2024 13:31
@Dav1dde Dav1dde mentioned this pull request Jan 23, 2024
Closed
@Dav1dde Dav1dde force-pushed the dav1d/cardinality-from-project-config branch from 5622129 to 85677ff Compare January 25, 2024 12:06
@Dav1dde Dav1dde marked this pull request as ready for review January 25, 2024 12:07
@Dav1dde Dav1dde requested a review from a team as a code owner January 25, 2024 12:07
@Dav1dde Dav1dde force-pushed the dav1d/cardinality-from-project-config branch from 85677ff to 39e438f Compare January 25, 2024 12:14
olksdr
olksdr approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Is there a test which checks the correctness of usage limits from the project config?

@Dav1dde Dav1dde enabled auto-merge (squash) January 25, 2024 14:29
@Dav1dde Dav1dde force-pushed the dav1d/cardinality-from-project-config branch from 14403b3 to 6f9d50a Compare January 25, 2024 14:33
@Dav1dde Dav1dde merged commit 1350614 into master Jan 25, 2024
20 checks passed
@Dav1dde Dav1dde deleted the dav1d/cardinality-from-project-config branch January 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

Assignees

@Dav1dde Dav1dde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dav1dde @olksdr