Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Add browser name to Sentry tags #3041

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Feb 1, 2024

This is a follow-up to this previous PR (#2969). We need to insert browser.name in the span's data field and then extract the value to sentry_tags.

@phacops phacops requested a review from a team as a code owner February 1, 2024 13:51
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a test before merging.

@phacops phacops merged commit dc38143 into master Feb 2, 2024
20 checks passed
@phacops phacops deleted the pierre/spans-add-browser-name-to-sentry-tags branch February 2, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants